[
https://issues.apache.org/jira/browse/HBASE-12298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740316#comment-14740316
]
Anoop Sam John commented on HBASE-12298:
----------------------------------------
bq.readVariableBytesFromArray(ByteBuff buf, int offset)
Need change the method name as per the change in parameter?
bq.ByteBufferedCell cell = (ByteBufferedCell)ptSearcher.current();
Why such unconditional type casting? Why cant the type be Cell only?
I see the special case just down. Pls add some comments why it is always BBCell
appendCurrentTokenToRowBuffer
Why cant do positional copy from Buf to Array?
Same in ColumnNodeReader#prependTokenToBuffer
// TODO : See if we can add only one API to do all this - I see... We dont
have positional get API.. It will be easy to add IMO. Suggest do it along with
this Jira. Will be simple API.
bq.this.block.asSubByteBuffer(this.absoluteValueOffset, valueLength, pair);
This pair comes from? The BB and offset is been properly taken from this?
(where?)
PrefixTreeCell - Why it has to keep a ref to ByteBuff block?
Why not use asSubBuffer and keep ref to ByteBuffer for value rather than having
a Pair and using it every time?
> Support BB usage in PrefixTree
> ------------------------------
>
> Key: HBASE-12298
> URL: https://issues.apache.org/jira/browse/HBASE-12298
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-12298.patch, HBASE-12298_1.patch,
> HBASE-12298_2.patch, HBASE-12298_3.patch, HBASE-12298_4 (1).patch,
> HBASE-12298_4 (1).patch, HBASE-12298_4 (1).patch, HBASE-12298_4 (1).patch,
> HBASE-12298_4 (1).patch, HBASE-12298_4.patch, HBASE-12298_4.patch,
> HBASE-12298_4.patch, HBASE-12298_4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
