[
https://issues.apache.org/jira/browse/HBASE-14361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741734#comment-14741734
]
Heng Chen commented on HBASE-14361:
-----------------------------------
{quote}
Do you want to take lock and set to null here:
216 if (this.sharedHtableCon != null)
{ 217 this.sharedHtableCon.close(); 218 }
{quote}
Yes, we can set {{sharedHtableCon}} to be {{null}} after close.
But i don't think there is any need to lock here, because
{{stopReplicationSinkServices}} is only called when RS is stopped,
And old code has no lock here too.
[~stack]
> ReplicationSink should create Connection instances lazily
> ---------------------------------------------------------
>
> Key: HBASE-14361
> URL: https://issues.apache.org/jira/browse/HBASE-14361
> Project: HBase
> Issue Type: Task
> Components: Replication
> Reporter: Nick Dimiduk
> Assignee: Heng Chen
> Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
> Attachments: HBASE-14361-0.98.patch, HBASE-14361.patch,
> HBASE-14361_v1.patch, hmaster.log
>
>
> Over on HBASE-12911 I have a patch that registers Connection instances with
> the metrics system. In both standalone server and tll client applications, I
> was surprised to see multiple connection objects showing up that are unused.
> These are pretty heavy objects, including lots of client threads for the
> batch pool. We should track these down and remove them -- if they're not some
> kind of phantom artifacts of my WIP patch over there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
