[
https://issues.apache.org/jira/browse/HBASE-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742219#comment-14742219
]
Hadoop QA commented on HBASE-14306:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12755567/HBASE-14306_v4.patch
against master branch at commit 36675c81fb2803418191e44c7eb9560a92a23411.
ATTACHMENT ID: 12755567
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15575//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15575//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15575//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15575//console
This message is automatically generated.
> Refine RegionGroupingProvider: fix issues and make it more scalable
> -------------------------------------------------------------------
>
> Key: HBASE-14306
> URL: https://issues.apache.org/jira/browse/HBASE-14306
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Affects Versions: 2.0.0, 1.1.2
> Reporter: Yu Li
> Assignee: Yu Li
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14306.patch, HBASE-14306_v2.patch,
> HBASE-14306_v3.patch, HBASE-14306_v3.patch, HBASE-14306_v4.patch
>
>
> There're multiple issues in RegionGroupingProvider, including:
> * The provider cache in it is using byte array as the key of
> ConcurrentHashMap, which is not right (the reason is
> [here|http://stackoverflow.com/questions/1058149/using-a-byte-array-as-hashmap-key-java])
> * It's using IdentityGroupingStrategy to get group and use it as key of the
> cache, which means the cache will include an entry for each region. This is
> especially unnecessary when using BoundedRegionGroupingProvider
> Besides fixing the above issues, I suggest to change
> BoundedRegionGroupingProvider from a *provider* to a pluggable *strategy*,
> which will make the whole picture much more clear.
> For more details, please refer to the patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
