[jira] [Commented] (HBASE-14287) Bootstrapping a cluster leaves temporary WAL directory laying around

[Lars George (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-14287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742414#comment-14742414
 ] 

Lars George commented on HBASE-14287:
-------------------------------------

For quick reference, the missing change is this:

{noformat}
       HRegion meta = HRegion.createHRegion(metaHRI, rd, c,
-          HTableDescriptor.META_TABLEDESC);
+          HTableDescriptor.META_TABLEDESC, null, true, true);
       setInfoFamilyCachingForMeta(true);
{noformat}

So the patch should be something like this:

{noformat}
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
index bcf9ba0..e8b26e6 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
@@ -537,7 +537,8 @@ public class MasterFileSystem {
       HRegionInfo metaHRI = new HRegionInfo(HRegionInfo.FIRST_META_REGIONINFO);
       HTableDescriptor metaDescriptor = new 
FSTableDescriptors(c).get(TableName.META_TABLE_NAME);
       setInfoFamilyCachingForMeta(metaDescriptor, false);
-      HRegion meta = HRegion.createHRegion(metaHRI, rd, c, metaDescriptor);
+      HRegion meta = HRegion.createHRegion(metaHRI, rd, c, metaDescriptor,
+        null, true, true);
       setInfoFamilyCachingForMeta(metaDescriptor, true);
       HRegion.closeHRegion(meta);
     } catch (IOException e) {
{noformat}

> Bootstrapping a cluster leaves temporary WAL directory laying around
> --------------------------------------------------------------------
>
>                 Key: HBASE-14287
>                 URL: https://issues.apache.org/jira/browse/HBASE-14287
>             Project: HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 1.0.2, 1.1.1
>            Reporter: Lars George
>            Priority: Minor
>
> When a new cluster is started, it creates a temporary WAL as {{hbase:meta}} 
> is created during bootstrapping the system. Then this log is closed before 
> properly opened on a region server. The temp WAL file is scheduled for 
> removal, moved to oldWALs and eventually claimed. Issue is that the WAL 
> directory with the temp region is not removed. For example:
> {noformat}
> drwxr-xr-x   - hadoop hadoop          0 2015-05-28 10:21 
> /hbase/WALs/hregion-65589555
> {noformat}
> The directory is empty and does not harm, but on the other hand it is not 
> needed anymore and should be removed. Cosmetic and good housekeeping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)