[ https://issues.apache.org/jira/browse/HBASE-14082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791758#comment-14791758 ]
Hudson commented on HBASE-14082: -------------------------------- FAILURE: Integrated in HBase-1.2 #181 (See [https://builds.apache.org/job/HBase-1.2/181/]) HBASE-14082 Add replica id to JMX metrics names (Lei Chen) (enis: rev 9f420d0ac6175a7245efe68c27fc32458bca1b86) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperStub.java * hbase-hadoop2-compat/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegionSourceImpl.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsRegion.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapper.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionWrapperImpl.java * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java > Add replica id to JMX metrics names > ----------------------------------- > > Key: HBASE-14082 > URL: https://issues.apache.org/jira/browse/HBASE-14082 > Project: HBase > Issue Type: Improvement > Components: metrics > Reporter: Lei Chen > Assignee: Lei Chen > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: 14082-v6.patch, HBASE-14082-v1.patch, > HBASE-14082-v2.patch, HBASE-14082-v3.patch, HBASE-14082-v4.patch, > HBASE-14082-v5.patch > > > Today, via JMX, one cannot distinguish a primary region from a replica. A > possible solution is to add replica id to JMX metrics names. The benefits may > include, for example: > # Knowing the latency of a read request on a replica region means the first > attempt to the primary region has timeout. > # Write requests on replicas are due to the replication process, while the > ones on primary are from clients. > # In case of looking for hot spots of read operations, replicas should be > excluded since TIMELINE reads are sent to all replicas. > To implement, we can change the format of metrics names found at > {code}Hadoop->HBase->RegionServer->Regions->Attributes{code} > from > {code}namespace_<namespace>_table_<tablename>_region_<regionname>_metric_<metricname>{code} > to > {code}namespace_<namespace>_table_<tablename>_region_<regionname>_replicaid_<replicaid>_metric_<metricname>{code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)