[
https://issues.apache.org/jira/browse/HBASE-14128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804470#comment-14804470
]
stack commented on HBASE-14128:
-------------------------------
+1 (after chatting about patch offline).
Nits below. Fix the latter minor on commit.
Seems fine making this non-pubilc since class is private, evolving...
static SnapshotManifest getSnapshotManifest
It is opaque doing the below where a restoreId becomes a tablename... just have
the passed in arg be tablename?
public static List<InputSplit> getSplits(Scan scan, SnapshotManifest manifest,
320 List<HRegionInfo> regionManifests, Path restoreDir, String
restoreId, Configuration conf)
> Fix inability to run Multiple MR over the same Snapshot
> -------------------------------------------------------
>
> Key: HBASE-14128
> URL: https://issues.apache.org/jira/browse/HBASE-14128
> Project: HBase
> Issue Type: Bug
> Components: mapreduce, snapshots
> Reporter: Matteo Bertozzi
> Assignee: santosh kumar
> Priority: Minor
> Labels: beginner, noob
> Attachments: HBASE-14128-v0.patch
>
>
> from the list, running multiple MR over the same snapshot does not work
> {code}
> public static void copySnapshotForScanner(Configuration conf, FileSystem ..
> RestoreSnapshotHelper helper = new RestoreSnapshotHelper(conf, fs,
> manifest, manifest.getTableDescriptor(), restoreDir, monitor, status);
> {code}
> the problem is that manifest.getTableDescriptor() will try to clone the
> snapshot with the same target name. ending up in "file already exist"
> exceptions.
> we just need to clone that descriptor and generate a new target table name
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
