[
https://issues.apache.org/jira/browse/HBASE-14455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14902473#comment-14902473
]
Hadoop QA commented on HBASE-14455:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12761601/HBASE-14455.patch
against master branch at commit 45d67435adc9195325bfccc78b7e1a0202a446e5.
ATTACHMENT ID: 12761601
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1825 checkstyle errors (more than the master's current 1823 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.ambari.server.api.services.AmbariMetaInfoTest.testGetRepositoryNoInternetUpdatedBaseUrl(AmbariMetaInfoTest.java:354)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15667//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15667//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15667//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15667//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15667//console
This message is automatically generated.
> Try to get rid of unused HConnection instance
> ----------------------------------------------
>
> Key: HBASE-14455
> URL: https://issues.apache.org/jira/browse/HBASE-14455
> Project: HBase
> Issue Type: Improvement
> Reporter: Heng Chen
> Priority: Minor
> Attachments: HBASE-14455.patch
>
>
> After HBASE-14361, we get rid of HConnection Instance in ReplicationSink in
> standalone mode. But there are still three HConnection Instance, i think the
> unused ones should be removed.
> The three instances are created below
> {code}
> 6 2015-09-21 16:05:36,401 INFO [10.0.3.80:60429.activeMasterManager]
> client.ConnectionImplementation:.
> 7 java.lang.Throwable
> 8 >---at
> org.apache.hadoop.hbase.client.ConnectionImplementation.<init>(ConnectionImplementation.java:217)
> 9 >---at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> 10 >---at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> 11 >---at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> 12 >---at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
> 13 >---at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:231)
> 14 >---at
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:118)
> 15 >---at
> org.apache.hadoop.hbase.master.ServerManager.<init>(ServerManager.java:222)
> 16 >---at
> org.apache.hadoop.hbase.master.ServerManager.<init>(ServerManager.java:212)
> 17 >---at
> org.apache.hadoop.hbase.master.HMaster.createServerManager(HMaster.java:853)
> 18 >---at
> org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:661)
> 19 >---at
> org.apache.hadoop.hbase.master.HMaster.access$500(HMaster.java:180)
> 20 >---at org.apache.hadoop.hbase.master.HMaster$1.run(HMaster.java:1670)
> 21 >---at java.lang.Thread.run(Thread.java:745)
> 22 2015-09-21 16:05:36,401 INFO [M:0;10.0.3.80:60429]
> client.ConnectionImplementation:.
> 23 java.lang.Throwable
> 24 >---at
> org.apache.hadoop.hbase.client.ConnectionImplementation.<init>(ConnectionImplementation.java:217)
> 25 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils$1.<init>(ConnectionUtils.java:128)
> 26 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils.createShortCircuitConnection(ConnectionUtils.java:128)
> 27 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.createClusterConnection(HRegionServer.java:686)
> 28 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.setupClusterConnection(HRegionServer.java:717)
> 29 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:730)
> 30 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:885)
> 31 >---at
> org.apache.hadoop.hbase.master.HMasterCommandLine$LocalHMaster.run(HMasterCommandLine.java:311)
> 32 >---at java.lang.Thread.run(Thread.java:745)
> 33 2015-09-21 16:05:36,401 INFO [RS:0;10.0.3.80:60431]
> client.ConnectionImplementation:.
> 34 java.lang.Throwable
> 35 >---at
> org.apache.hadoop.hbase.client.ConnectionImplementation.<init>(ConnectionImplementation.java:217)
> 36 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils$1.<init>(ConnectionUtils.java:128)
> 37 >---at
> org.apache.hadoop.hbase.client.ConnectionUtils.createShortCircuitConnection(ConnectionUtils.java:128)
> 38 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.createClusterConnection(HRegionServer.java:686)
> 39 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.setupClusterConnection(HRegionServer.java:717)
> 40 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.preRegistrationInitialization(HRegionServer.java:730)
> 41 >---at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:885)
> 42 >---at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
