[ 
https://issues.apache.org/jira/browse/HBASE-13324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905734#comment-14905734
 ] 

Hadoop QA commented on HBASE-13324:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12762028/HBASE-13324.patch
  against master branch at commit 5e26ae043dde217aeda29d9b67e290728adade89.
  ATTACHMENT ID: 12762028

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15703//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15703//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15703//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15703//console

This message is automatically generated.

> o.a.h.h.Coprocessor should be LimitedPrivate("Coprocessor")
> -----------------------------------------------------------
>
>                 Key: HBASE-13324
>                 URL: https://issues.apache.org/jira/browse/HBASE-13324
>             Project: HBase
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 1.0.0
>            Reporter: Lars George
>            Assignee: Andrew Purtell
>            Priority: Minor
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.15, 1.0.3, 1.1.3
>
>         Attachments: HBASE-13324.patch
>
>
> The matching classes, like CoprocessorService, which also needs to be added 
> to a developers class for, e.g. an Endpoint, are all PrivateLimited(COPRO) it 
> seems. I am not sure why they are in different packages though, the former is 
> in hbase-client, and the latter in hbase-server. Is this intentional?
> This JIRA is about fixing the annotation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to