[
https://issues.apache.org/jira/browse/HBASE-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906184#comment-14906184
]
Hadoop QA commented on HBASE-14404:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12762104/HBASE-14404-0.98-v3.patch
against 0.98 branch at commit 5b7894f92ba3e9ff700da1e9194ebb4774d8b71e.
ATTACHMENT ID: 12762104
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
28 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15717//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15717//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15717//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15717//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15717//console
This message is automatically generated.
> Backport HBASE-14098 (Allow dropping caches behind compactions) to 0.98
> -----------------------------------------------------------------------
>
> Key: HBASE-14404
> URL: https://issues.apache.org/jira/browse/HBASE-14404
> Project: HBase
> Issue Type: Task
> Reporter: Andrew Purtell
> Assignee: Liu Shaohui
> Fix For: 0.98.15
>
> Attachments: HBASE-14404-0.98-v3.patch, HBASE-14404-0.98.patch,
> HBASE-14404-0.98.patch, v3-v2.diff
>
>
> HBASE-14098 adds a new configuration toggle -
> "hbase.hfile.drop.behind.compaction" - which if set to "true" tells
> compactions to drop pages from the OS blockcache after write. It's on by
> default where committed so far but a backport to 0.98 would default it to
> off. (The backport would also retain compat methods to LimitedPrivate
> interface StoreFileScanner.) What could make it a controversial change in
> 0.98 is it changes the default setting of
> 'hbase.regionserver.compaction.private.readers' from "false" to "true". I
> think it's fine, we use private readers in production. They're stable and do
> not present perf issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
