[ 
https://issues.apache.org/jira/browse/HBASE-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907425#comment-14907425
 ] 

Andrew Purtell commented on HBASE-14227:
----------------------------------------

What I want to see happen is in the original description of this issue:
{quote}
There are a number of APIs that came in with MOB that are not new actions for 
HBase, simply new actions for a MOB implementation:
- compactMob
- compactMobs
- majorCompactMob
- majorCompactMobs
- getMobCompactionState

And in HBaseAdmin:
- validateMobColumnFamily

Remove these special cases from the Admin API where possible by folding them 
into existing APIs.
{quote}

The current patch achieves this aim. I think it is mostly ready to go but have 
some comments above that could be addressed, especially the use of 
getClusterStatus (please fix that)

If your patch also achieves the described aim [[email protected]], then I 
would be happy either way and you and [~chenheng] can decide what you'd prefer.

> Fold special cased MOB APIs into existing APIs
> ----------------------------------------------
>
>                 Key: HBASE-14227
>                 URL: https://issues.apache.org/jira/browse/HBASE-14227
>             Project: HBase
>          Issue Type: Task
>          Components: mob
>    Affects Versions: 2.0.0
>            Reporter: Andrew Purtell
>            Assignee: Heng Chen
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14227.patch, HBASE-14227_v1.patch, 
> HBASE-14227_v2.patch, HBASE-14227_v3.patch, HBASE-14227_v4.patch, 
> HBASE-14227_v5.patch, HBASE-14227_v5.patch
>
>
> There are a number of APIs that came in with MOB that are not new actions for 
> HBase, simply new actions for a MOB implementation:
> - compactMob
> - compactMobs
> - majorCompactMob
> - majorCompactMobs
> - getMobCompactionState
> And in HBaseAdmin:
> - validateMobColumnFamily
> Remove these special cases from the Admin API where possible by folding them 
> into existing APIs.
> We definitely don't need one method for a singleton and another for 
> collections.
> Ideally we will not have any APIs named *Mob when finished, whether MOBs are 
> in use on a table or not should be largely an internal detail. Exposing as 
> schema option would be fine, this conforms to existing practice for other 
> features.
> Marking critical because I think removing the *Mob special cased APIs should 
> be a precondition for release of this feature either in 2.0 or as a backport.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to