[
https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908370#comment-14908370
]
stack commented on HBASE-14490:
-------------------------------
bq. According to experience, size of rpc request << response on server side.
Request is big when we are putting Cells.
bq. 2.Maintain BoundedByteBufferPool need some cost.
You would rather have a reusable buffer made once per Connection? That'd work
too.
On the patch, why do we need isAllocateData ? Can't we just check for data ==
null?
> [RpcServer] reuse request read buffer
> -------------------------------------
>
> Key: HBASE-14490
> URL: https://issues.apache.org/jira/browse/HBASE-14490
> Project: HBase
> Issue Type: Improvement
> Components: IPC/RPC
> Affects Versions: 2.0.0
> Reporter: Zephyr Guo
> Assignee: Zephyr Guo
> Priority: Minor
> Attachments: HBASE-14490-v1.patch, HBASE-14490-v2.patch
>
>
> Reuse buffer to read request.It's not necessary free data's buffer for each
> RPC.It maybe can cause memory fragmentation.Allocate buffer also has some
> cost.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
