[ 
https://issues.apache.org/jira/browse/HBASE-14490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909418#comment-14909418
 ] 

Zephyr Guo commented on HBASE-14490:
------------------------------------

Thanks for [~anoop.hbase] review.
{quote}
I also thought in same line as Stack and was reading again the patch, why we 
need the boolean.
{quote}

Seem not need it.I has removed it in patch-v5.

> [RpcServer] reuse request read buffer
> -------------------------------------
>
>                 Key: HBASE-14490
>                 URL: https://issues.apache.org/jira/browse/HBASE-14490
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>    Affects Versions: 2.0.0, 1.1.2
>            Reporter: Zephyr Guo
>            Assignee: Zephyr Guo
>            Priority: Minor
>         Attachments: HBASE-14490-v1.patch, HBASE-14490-v2.patch, 
> HBASE-14490-v3.patch, HBASE-14490-v4.patch
>
>
> Reuse buffer to read request.It's not necessary free data's buffer for each 
> RPC.It maybe can cause memory fragmentation.Allocate buffer also has some 
> cost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to