[
https://issues.apache.org/jira/browse/HBASE-14497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934888#comment-14934888
]
Hadoop QA commented on HBASE-14497:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12764185/HBASE-14497-master-v4.patch
against master branch at commit 6ad6273ddaedb7a3a21ef391d4381c19a474e3b3.
ATTACHMENT ID: 12764185
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // create one storefile contains many rows will be skipped to check
StoreFileScanner.seekToPreviousRow
+ // create one memstore contains many rows will be skipped to check
MemStoreScanner.seekToPreviousRow
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15795//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15795//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15795//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15795//console
This message is automatically generated.
> Reverse Scan threw StackOverflow caused by readPt checking
> ----------------------------------------------------------
>
> Key: HBASE-14497
> URL: https://issues.apache.org/jira/browse/HBASE-14497
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0, 0.98.14, 1.3.0
> Reporter: Yerui Sun
> Attachments: HBASE-14497-0.98.patch, HBASE-14497-branch-1-v2.patch,
> HBASE-14497-branch-1.patch, HBASE-14497-master-v2.patch,
> HBASE-14497-master-v3.patch, HBASE-14497-master-v3.patch,
> HBASE-14497-master-v4.patch, HBASE-14497-master.patch
>
>
> I met stack overflow error in StoreFileScanner.seekToPreviousRow using
> reversed scan. I searched and founded HBASE-14155, but it seems to be a
> different reason.
> The seekToPreviousRow will fetch the row which closest before, and compare
> mvcc to the readPt, which acquired when scanner created. If the row's mvcc is
> bigger than readPt, an recursive call of seekToPreviousRow will invoked, to
> find the next closest before row.
> Considering we created a scanner for reversed scan, and some data with
> smaller rows was written and flushed, before calling scanner next. When
> seekToPreviousRow was invoked, it would call itself recursively, until all
> rows which written after scanner created were iterated. The depth of
> recursive calling stack depends on the count of rows, the stack overflow
> error will be threw if the count of rows is large, like 10000.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)