[ 
https://issues.apache.org/jira/browse/HBASE-14510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935161#comment-14935161
 ] 

Hadoop QA commented on HBASE-14510:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12764213/HBASE-14510.patch
  against master branch at commit 2ea70c7e6c70c4bd689b79718999a948001f3b21.
  ATTACHMENT ID: 12764213

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s): 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15802//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15802//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15802//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15802//console

This message is automatically generated.

> Can not set coprocessor from Shell after HBASE-14224
> ----------------------------------------------------
>
>                 Key: HBASE-14510
>                 URL: https://issues.apache.org/jira/browse/HBASE-14510
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 0.98.14, 1.3.0
>            Reporter: Yerui Sun
>         Attachments: HBASE-14510.patch
>
>
> I was able to set coprocessors for table by shell normally, but it didn't 
> worked now.
> Here's the shell output (omit really jar path and coprocessor classname):
> {code}
> HBase Shell; enter 'help<RETURN>' for list of supported commands.
> Type "exit<RETURN>" to leave the HBase Shell
> Version 1.3.0-SNAPSHOT, 642273bc2a5a415eba6f1592a439a6b2b53a70a9, Tue Sep 29 
> 15:58:28 CST 2015
> hbase(main):001:0> describe 'test'
> Table test is ENABLED
> test
> COLUMN FAMILIES DESCRIPTION
> {NAME => 'f', DATA_BLOCK_ENCODING => 'NONE', BLOOMFILTER => 'ROW', 
> REPLICATION_SCOPE => '0', VERSIONS => '1', COMPRESSION => 'NONE', 
> MIN_VERSIONS => '0', TTL => 'FOREVER', KEEP_DELETED_CELLS => 'FALSE', B
> LOCKSIZE => '65536', IN_MEMORY => 'false', BLOCKCACHE => 'true'}
> 1 row(s) in 0.4370 seconds
> hbase(main):002:0> alter 'test', 
> 'coprocessor'=>'hdfs:///some.jar|com.somepackage.SomeObserver|1001'
> Updating all regions with the new schema...
> 1/1 regions updated.
> Done.
> 0 row(s) in 1.9760 seconds
> hbase(main):003:0> describe 'test'
> Table test is ENABLED
> test, {TABLE_ATTRIBUTES => {coprocessor$1 => 
> '|hdfs:///some.jar|com.somepackage.SomeObserver|1001|1073741823|'}
> COLUMN FAMILIES DESCRIPTION
> {NAME => 'f', DATA_BLOCK_ENCODING => 'NONE', BLOOMFILTER => 'ROW', 
> REPLICATION_SCOPE => '0', VERSIONS => '1', COMPRESSION => 'NONE', 
> MIN_VERSIONS => '0', TTL => 'FOREVER', KEEP_DELETED_CELLS => 'FALSE', B
> LOCKSIZE => '65536', IN_MEMORY => 'false', BLOCKCACHE => 'true'}
> 1 row(s) in 0.0180 seconds
> {code}
> I checked the recent commits and found HBASE-14224 is related to. It's an 
> important improvement, but made a mistake in alter() of admin.rb, line 587. 
> As the value is coprocess spec string but not only class name, here should 
> use htd.setCoprocessorWithSpec instead of htd.setCoprocessor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to