[
https://issues.apache.org/jira/browse/HBASE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136793#comment-13136793
]
jirapos...@reviews.apache.org commented on HBASE-2856:
------------------------------------------------------
bq. On 2011-10-17 06:06:23, Kannan Muthukkaruppan wrote:
bq. > Amit: Did you rebase before uploading the new patch. That,
unfortunately, is making it hard to isolate the changes between r6 and r7. Will
review tomorrow morning.
bq. >
bq. > But I did read your description about the issues you mentioned.
bq. >
bq. > Regarding (b)-- we had already discussed in person. That makes sense.
bq. >
bq. > And really nice catch on (a) too!! That is indeed subtle and tricky.
Super!!!
bq. >
bq.
bq. Amitanand Aiyer wrote:
bq. Looks like a lot has changed since the original revision that I based
my first patch off.
bq.
bq. Please disregard v7.
bq.
bq. Let me submit these modifications as a separate diff. I have a
sub-jira created for each part.
bq.
bq.
Seems like we are all basically +1 on this patch upto to some point - could we
commit till there? We can add the other changes as separate tasks under the
same umbrella task.
The other diffs are based on this diff... and they are separate issues from
what this is addressing (persisting memstoreTS). Its getting confusing if we
keep adding to this diff.
- Karthik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2224/#review2614
-----------------------------------------------------------
On 2011-10-15 04:08:41, Amitanand Aiyer wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2224/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-15 04:08:41)
bq.
bq.
bq. Review request for Ted Yu, Michael Stack, Kannan Muthukkaruppan, and
Karthik Ranganathan.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. address the 2856 issues by writing the memstoreTS to the disk.
bq.
bq. version v11 of the patch.
bq.
bq. uploading it here for easier review process.
bq.
bq.
bq. This addresses bug HBASE-2856.
bq. https://issues.apache.org/jira/browse/HBASE-2856
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /pom.xml 1183581
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileReader.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/ColumnCount.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java
1183581
bq.
/src/main/java/org/apache/hadoop/hbase/regionserver/ExplicitColumnTracker.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1183581
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java
1183581
bq.
/src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java
1183581
bq.
/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
1183581
bq.
/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1183581
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
1183581
bq.
/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
1183581
bq. /src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
1183581
bq. /src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 1183581
bq. /src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java 1183581
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java
1183581
bq. /src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileWriterV2.java
1183581
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
1183581
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
1183581
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
1183581
bq. /src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
1183581
bq.
bq. Diff: https://reviews.apache.org/r/2224/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. mvn test
bq.
bq.
bq. Thanks,
bq.
bq. Amitanand
bq.
bq.
> TestAcidGuarantee broken on trunk
> ----------------------------------
>
> Key: HBASE-2856
> URL: https://issues.apache.org/jira/browse/HBASE-2856
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.89.20100621
> Reporter: ryan rawson
> Assignee: Amitanand Aiyer
> Priority: Blocker
> Fix For: 0.94.0
>
> Attachments: 2856-v2.txt, 2856-v3.txt, 2856-v4.txt, 2856-v5.txt,
> acid.txt
>
>
> TestAcidGuarantee has a test whereby it attempts to read a number of columns
> from a row, and every so often the first column of N is different, when it
> should be the same. This is a bug deep inside the scanner whereby the first
> peek() of a row is done at time T then the rest of the read is done at T+1
> after a flush, thus the memstoreTS data is lost, and previously 'uncommitted'
> data becomes committed and flushed to disk.
> One possible solution is to introduce the memstoreTS (or similarly equivalent
> value) to the HFile thus allowing us to preserve read consistency past
> flushes. Another solution involves fixing the scanners so that peek() is not
> destructive (and thus might return different things at different times alas).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
