[
https://issues.apache.org/jira/browse/HBASE-14511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939355#comment-14939355
]
ramkrishna.s.vasudevan commented on HBASE-14511:
------------------------------------------------
I think this is nice idea.
Minor nit
{code}
private void notifyPluginsOnAppend(Cell cell)
1035 {
{code}
The formatting looks odd here. Pls check.
Also I can understand why we need a notifyPluginsOnAppendMetadata - because we
could add some meta info on closing the writer and it is attached to the file -
but why is this notifyPluginsOnAppend(Cell) needed? Or is the purpose is to
make the plugin know how many cells are being added as done in example? Anyway
that should be a core work right?
> StoreFile.Writer Meta Plugin
> ----------------------------
>
> Key: HBASE-14511
> URL: https://issues.apache.org/jira/browse/HBASE-14511
> Project: HBase
> Issue Type: New Feature
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Attachments: HBASE-14511.v1.patch, HBASE-14511.v2.patch
>
>
> During my work on a new compaction policies (HBASE-14468, HBASE-14477) I had
> to modify the existing code of a StoreFile.Writer to add additional meta-info
> required by these new policies. I think that it should be done by means of a
> new Plugin framework, because this seems to be a general capability/feature.
> As a future enhancement this can become a part of a more general
> StoreFileWriter/Reader plugin architecture. But I need only Meta section of a
> store file.
> This could be used, for example, to collect rowkeys distribution information
> during hfile creation. This info can be used later to find the optimal region
> split key or to create optimal set of sub-regions for M/R jobs or other jobs
> which can operate on a sub-region level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
