[
https://issues.apache.org/jira/browse/HBASE-4120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137293#comment-13137293
]
[email protected] commented on HBASE-4120:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1421/#review2880
-----------------------------------------------------------
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6449>
This class doesn't belong to ipc module.
How about lifting this class and PriorityJobQueue to
org/apache/hadoop/hbase ?
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6450>
This key should be named PRI_KEY_ACTION_PRIORITY. The string should be
"_action_priority"
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6438>
Should read 'The priority map caches the region's priority in memory.'
Originally there was one javadoc for all the maps. Now this sentence should
be specific.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6439>
Should read 'Key is the region name which usually is obtained from the IPC
call'
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6445>
Under what circumstances would a region carry different priority than the
table it belongs ?
If there is such scenario, we should add a test for RegionPriority.
Otherwise this map can be folded into tablePriMap.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6442>
This map should be named scannerRegionMap
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6437>
The variable name can be improved.
How about naming it scannerPriMap ?
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6448>
Class name is still incorrect, missing hbase component.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6447>
Default value here is different from the value on line 70.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6436>
Should read 'priority should be between'.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6435>
Should read 'to set table action priority'
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6440>
This variable should be named actionPriority
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
<https://reviews.apache.org/r/1421/#comment6441>
This variable should be called scannerId.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityHBaseServer.java
<https://reviews.apache.org/r/1421/#comment6451>
This parameter should be named priorityHandlerCount so that it is
consistent with usage in HBaseServer.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityJobQueue.java
<https://reviews.apache.org/r/1421/#comment6446>
Should read 'which have same or higher priority'
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/allocation/test/TestForTablePriority.java
<https://reviews.apache.org/r/1421/#comment6444>
Typo: should be setTablePriority
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/allocation/test/TestForTablePriority.java
<https://reviews.apache.org/r/1421/#comment6443>
Typo: should be setTablePriority
- Ted
On 2011-10-27 13:05:36, Jia Liu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1421/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-27 13:05:36)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Patch used for table priority alone,In this patch, not only tables can
have different priorities but also the different actions like
"get","scan","put" and "delete" can have priorities.
bq.
bq.
bq. This addresses bug HBase-4120.
bq. https://issues.apache.org/jira/browse/HBase-4120
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
1189169
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
1189169
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityFunction.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityHBaseServer.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/PriorityJobQueue.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1189169
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/allocation/test/TestForActionPriority.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/allocation/test/TestForPriorityJobQueue.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/allocation/test/TestForTablePriority.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1421/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested with test cases in TestCase_For_TablePriority_trunk_v1.patch
bq. please apply the patch of HBASE-4181 first,in some circumstances this bug
will affect the performance of client.
bq.
bq.
bq. Thanks,
bq.
bq. Jia
bq.
bq.
> isolation and allocation
> ------------------------
>
> Key: HBASE-4120
> URL: https://issues.apache.org/jira/browse/HBASE-4120
> Project: HBase
> Issue Type: New Feature
> Components: master, regionserver
> Affects Versions: 0.90.2, 0.90.3, 0.90.4, 0.92.0
> Reporter: Liu Jia
> Fix For: 0.94.0
>
> Attachments: Design_document_for_HBase_isolation_and_allocation.pdf,
> Design_document_for_HBase_isolation_and_allocation_Revised.pdf,
> HBase_isolation_and_allocation_user_guide.pdf,
> Performance_of_Table_priority.pdf, System Structure.jpg, TablePriority.patch
>
>
> The HBase isolation and allocation tool is designed to help users manage
> cluster resource among different application and tables.
> When we have a large scale of HBase cluster with many applications running on
> it, there will be lots of problems. In Taobao there is a cluster for many
> departments to test their applications performance, these applications are
> based on HBase. With one cluster which has 12 servers, there will be only one
> application running exclusively on this server, and many other applications
> must wait until the previous test finished.
> After we add allocation manage function to the cluster, applications can
> share the cluster and run concurrently. Also if the Test Engineer wants to
> make sure there is no interference, he/she can move out other tables from
> this group.
> In groups we use table priority to allocate resource, when system is busy; we
> can make sure high-priority tables are not affected lower-priority tables
> Different groups can have different region server configurations, some groups
> optimized for reading can have large block cache size, and others optimized
> for writing can have large memstore size.
> Tables and region servers can be moved easily between groups; after changing
> the configuration, a group can be restarted alone instead of restarting the
> whole cluster.
> git entry : https://github.com/ICT-Ope/HBase_allocation .
> We hope our work is helpful.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
