[ 
https://issues.apache.org/jira/browse/HBASE-14525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944505#comment-14944505
 ] 

Anoop Sam John commented on HBASE-14525:
----------------------------------------

{code}
 try {
7022                  checkFamily(family.getKey());
7023                } catch (NoSuchColumnFamilyException e) {
7024                  LOG.warn("Unknown column family in append operation", e);
7025                  continue;
7026                }
{code}
So we will just log the invalid cf and continue with others?  IMO we can do 
same was as put(Put).. Pls see that. When any invalid CF is part of the 
Mutation, it will throw Exception and fail the op.

> Append and increment operation throws NullPointerException when appending on 
> non-existing column families.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14525
>                 URL: https://issues.apache.org/jira/browse/HBASE-14525
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 2.0.0
>            Reporter: Abhishek Kumar
>            Assignee: Abhishek Kumar
>            Priority: Minor
>         Attachments: HBASE-14525.patch
>
>
> When performing append operation on non-existing column families, 
> NullPointerException is thrown in hbase shell as shown below:
> {noformat}
> hbase(main):007:0> append 't1', 'r1', 'none:c1', '123'
> ERROR: java.io.IOException
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2175)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:106)
> at org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.HRegion.doGet(HRegion.java:6987)
> at org.apache.hadoop.hbase.regionserver.HRegion.append(HRegion.java:7048)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.append(RSRpcServices.java:580)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2206)
> at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:32452)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2133)
> ... 4 more
> {noformat}
> This seems to be caused by absence of check for valid family names as done in 
> other operations like 'Put' in HRegion.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to