[
https://issues.apache.org/jira/browse/HBASE-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137461#comment-13137461
]
stack commented on HBASE-4304:
------------------------------
{code}
long now = System.currentTimeMillis();
long diff = (now-ts)/1000;
- if (diff == 0) diff = 1; // sigh this is crap.
+ if (diff < 0.5){
{code}
diff is a long. It can't be 0.5. You want to use a float or something?
Should the below instead be an accessor on RSM rather than expose the data
member?
{code}
- private final MetricsRate requests = new MetricsRate("requests", registry);
+ public final MetricsRate requests = new MetricsRate("requests", registry);
{code}
Good stuff Li. Agree on failing tests.
> requestsPerSecond counter stuck at 0
> ------------------------------------
>
> Key: HBASE-4304
> URL: https://issues.apache.org/jira/browse/HBASE-4304
> Project: HBase
> Issue Type: Bug
> Components: master, regionserver
> Affects Versions: 0.92.0
> Reporter: Todd Lipcon
> Assignee: Li Pi
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 4304v1.txt, 4304v2.txt, 4304v3.txt
>
>
> Running trunk @ r1163343, all of the requestsPerSecond counters are showing 0
> both in the master UI and in the RS UI. The writeRequestsCount metric is
> properly updating in the RS UI.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
