[ 
https://issues.apache.org/jira/browse/HBASE-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946149#comment-14946149
 ] 

Anoop Sam John commented on HBASE-14398:
----------------------------------------

bq.Why does ByteBufferedCell have to have getFamilyPositionInByteBuffer at all? 
Why can't I just call getFamilyOffset on the ByteBufferedCell implementation 
and it returns me an offset that makes sense on the ByteBuffer returned out of 
getFamilyByteBuffer?
When the cell is backed by DBB or byte[], we have to support the 
getFamilyArray() API. So when it is DBB, we have to do copy to a temp byte[]. 
So when getFamilyOffset() is used along with getFamilyArray(), we have to 
return 0 as the offset. Whereas the offset to family in get BB, will be a non 0 
value.
We have to support getFamilyArray API on BBCell also. Else we will have to have 
the hasArray() API.  We had these discussion long back.

> Create the fake keys required in the scan path to avoid copy to byte[]
> ----------------------------------------------------------------------
>
>                 Key: HBASE-14398
>                 URL: https://issues.apache.org/jira/browse/HBASE-14398
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14398.patch, HBASE-14398_1.patch
>
>
> Already we have created some fake keys for the ByteBufferedCells so that we 
> can avoid the copy requried to create fake keys. This JIRA aims to fill up 
> all such places so that the Offheap BBs are not copied to onheap byte[].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to