[
https://issues.apache.org/jira/browse/HBASE-14574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947651#comment-14947651
]
Hadoop QA commented on HBASE-14574:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12765429/14574.txt
against master branch at commit d80c7e95ec7ef4811b83224a87ee6883f67f2d62.
ATTACHMENT ID: 12765429
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.TestRegionServerHostname.testInvalidRegionServerHostnameAbortsServer(TestRegionServerHostname.java:61)
at
org.apache.hadoop.hbase.regionserver.TestSeekOptimizations.testMultipleTimestampRanges(TestSeekOptimizations.java:163)
at
org.apache.hadoop.hbase.regionserver.TestHRegion.testBasicSplit(TestHRegion.java:3522)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15902//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15902//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15902//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15902//console
This message is automatically generated.
> TableOutputFormat#getRecordWriter javadoc misleads
> --------------------------------------------------
>
> Key: HBASE-14574
> URL: https://issues.apache.org/jira/browse/HBASE-14574
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 14574.txt
>
>
> Some feedback from a user was that it was not plain that getRecordWriter
> returns a NEW instance on each invocation. The base Interface javadoc on
> OutputWriter would seem to indicate there is one instance for a whole
> 'job'... That is not what we do. So, just reading the javadoc, you'd not
> bother with closing the returned record writer since the framework will do
> the close up for you; thats what the javadoc implies. This made it so it
> seemed hbase was losing writes.
> Lets fix in javadoc at least.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
