[
https://issues.apache.org/jira/browse/HBASE-8963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950201#comment-14950201
]
Sebastian Cotarla commented on HBASE-8963:
------------------------------------------
I would like to help but I can't figure out which solution are you
implementing.
[~lhofhansl] initially proposed to "make the retention period configurable per
table, and have 0 indicate immediate deletion". I like the idea because from a
user point of view it is intuitive and consistent with
"hbase.master.hfilecleaner.ttl". If we go this route then I would expect both
config property and table attribute to be taken into account when deciding if a
file needs to be archived and when it needs to be deleted from the archive. I
would also expect table attribute to have priority over global configuration.
The new attribute HFILECLEANER_TTL follows the above reasoning so I am happy
with it (much better than SKIP_ARCHIVING_ON_DELETION), however looking at patch
v10 I don't see it used in two places I would expect it to be: HFileArchiver &
TimeToLiveHFileCleaner.
Later on Lars also added:
{quote}
It's not actually as simple as I thought. At the time we're archiving/deleting
HFiles we do not necessarily have access to the table's metadata, it's
expensive to read the table description (in the region or family case). When
the table is dropped, we'd need to keep the TTL information somewhere else.
{quote}
which worries me. The first part, related to access to table's metadata, was
addressed to some extent (ony in HFileArchiver) by v9 patch. The "table
dropped" case is probably harder to tackle - I would propose to fall back to
the global config when table does not exist anymore and we need to decide what
to do with remaining hfiles.
> Add configuration option to skip HFile archiving
> ------------------------------------------------
>
> Key: HBASE-8963
> URL: https://issues.apache.org/jira/browse/HBASE-8963
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0
>
> Attachments: 8963-v10.txt, HBASE-8963.trunk.v1.patch,
> HBASE-8963.trunk.v2.patch, HBASE-8963.trunk.v3.patch,
> HBASE-8963.trunk.v4.patch, HBASE-8963.trunk.v5.patch,
> HBASE-8963.trunk.v6.patch, HBASE-8963.trunk.v7.patch,
> HBASE-8963.trunk.v8.patch, HBASE-8963.trunk.v9.patch
>
>
> Currently HFileArchiver is always called when a table is dropped or compacted.
> A configuration option (either global or per table) should be provided so
> that archiving can be skipped when table is deleted or compacted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
