[
https://issues.apache.org/jira/browse/HBASE-4689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137728#comment-13137728
]
[email protected] commented on HBASE-4689:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2587/
-----------------------------------------------------------
(Updated 2011-10-27 23:26:27.328348)
Review request for hbase, Mikhail Bautin, Pritam Damania, Prakash Khemani,
Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and
Nicolas Spiegelberg.
Changes
-------
Address Nicolas' comments.
Summary
-------
In r1182034, the per table/cf for rpc* metrics has a bug. It will only show cf
level metrics even though we enabled the per table level metrics.
Fix this bug here.
This addresses bug HBASE-4689.
https://issues.apache.org/jira/browse/HBASE-4689
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 6c821c0
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
8776ffe
src/test/java/org/apache/hadoop/hbase/regionserver/metrics/TestSchemaMetrics.java
c03532a
Diff: https://reviews.apache.org/r/2587/diff
Testing
-------
Passed all the unit tests and tested the rpc metrics in the dev cluster
Thanks,
Liyin
> [89-fb] Make the table level metrics work with rpc* metrics
> -----------------------------------------------------------
>
> Key: HBASE-4689
> URL: https://issues.apache.org/jira/browse/HBASE-4689
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.89.20100924
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: hbase-4689.patch
>
>
> In r1182034, the per table/cf for rpc* metrics has a bug. It will only show
> cf level metrics even though we enabled the per table level metrics.
> Fix this bug here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
