[ 
https://issues.apache.org/jira/browse/HBASE-14398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953619#comment-14953619
 ] 

stack commented on HBASE-14398:
-------------------------------

bq. We should integrate the why into the Interface doc? I can write it up if 
that'd help

I did the below a few days ago. I think its enough to satisfy the above. 
Hopefully I'll remember to read it next time I wonder why getFamilyPosition and 
getFamilyOffset in a Cell backed by ByteBufferedCell (smile)

"It also has getters of the *position* within a ByteBuffer where these
 * field bytes begin. These are needed because a single ByteBuffer may back one 
or many Cell
 * instances -- it depends on the implementation -- so the ByteBuffer position 
as returned by
 * {@link ByteBuffer#arrayOffset()} cannot be relied upon. Also, do not confuse 
these position
 * methods with the getXXXOffset methods from the super Interface, {@link 
Cell}; dependent up on
 * implementation, the Cell getXXXOffset methods can return the same value as a 
call to its
 * equivalent position method from below BUT they can also stray; if a 
ByteBufferedCell, use the
 * below position methods to find where a field begins."

> Create the fake keys required in the scan path to avoid copy to byte[]
> ----------------------------------------------------------------------
>
>                 Key: HBASE-14398
>                 URL: https://issues.apache.org/jira/browse/HBASE-14398
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14398.patch, HBASE-14398_1.patch
>
>
> Already we have created some fake keys for the ByteBufferedCells so that we 
> can avoid the copy requried to create fake keys. This JIRA aims to fill up 
> all such places so that the Offheap BBs are not copied to onheap byte[].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to