[
https://issues.apache.org/jira/browse/HBASE-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Wang updated HBASE-14586:
--------------------------------
Attachment: hbase-14586.002.patch
Here's a patch which moves jacoco execution under a new "jacoco" profile which
is off by default. I also removed the hbase.skip-jacoco property since I think
the same functionality is handled by the profile.
I tested with Andy's mvn line, I think it's working:
{noformat}
-> % mvn clean package -Dtest=TestCheckTestClasses -Pjacoco
...
[INFO] --- jacoco-maven-plugin:0.7.5.201505241946:report (report) @
hbase-server ---
[INFO] Analyzed bundle 'Apache HBase - Server' with 1595 classes
{noformat}
Ran the same thing with "-Pjacoco,os.windows" and saw that same output, so I
think the cygwin argLine is also being handled correctly.
I also saw this warning with os.windows, so removed the duplicate
preferIPv4Stack definition in os.windows (it's already in the argLine):
{noformat}
[WARNING] The system property java.net.preferIPv4Stack is configured twice! The
property appears in <argLine/> and any of <systemPropertyVariables/>,
<systemProperties/> or user property.
{noformat}
If we're okay with this approach, I assume an HBase committer can take of
updating any code coverage jobs / precommit as appropriate, as well as related
documentation. If I can get some pointers, I'm happy to provide patches to help
speed it along.
> Remove extraneous ${argLine} references in pom
> ----------------------------------------------
>
> Key: HBASE-14586
> URL: https://issues.apache.org/jira/browse/HBASE-14586
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 1.1.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Priority: Minor
> Attachments: hbase-14586.001.patch, hbase-14586.001.patch,
> hbase-14586.002.patch
>
>
> The pom.xml has a line like this for the Surefire argLine, which has an extra
> ${argLine} reference. Recommend changes like this:
> {noformat}
> - <argLine>${hbase-surefire.argLine} ${argLine}</argLine>
> + <argLine>${hbase-surefire.argLine}</argLine>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
