[
https://issues.apache.org/jira/browse/HBASE-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964042#comment-14964042
]
stack edited comment on HBASE-14636 at 10/19/15 9:06 PM:
---------------------------------------------------------
The patch seems to be doing well in my testbed (it takes a good few hours to
run). Will keep you posted. We got much further than w/o the patch.
On the patch:
this.curBlock.getMemoryType() == MemoryType.SHARED
Can we keep this internal to the block rather than have HFileScannerImpl have
to know about SHARED?... Maybe a method on block...
Sort of similiar, this bit where we do a check every two seconds...... could we
change it to be size based?
Maybe not.... every two seconds seems a little arbitrary. Pity there not a more
'natural' place to do the housekeeping.
I had other comments here but edited it out because I remembered how this stuff
worked after I'd made the comment... my comment made no sense after I
remembered what shipped does. Please excuse.
was (Author: stack):
The patch seems to be doing well in my testbed (it takes a good few hours to
run). Will keep you posted. We got much further than w/o the patch.
On the patch:
this.curBlock.getMemoryType() == MemoryType.SHARED
Can we keep this internal to the block rather than have HFileScannerImpl have
to know about SHARED?... Maybe a method on block...
Sort of similiar, this bit where we do a check every two seconds...... could we
change it to be size based?
private static final long COMPACTION_PROGRESS_SHIPPED_CALL_INTERVAL = 2 *
1000;
Could it be a method in KeyValueScanner that checks if we need to ship?
Could call kvs.shipped(); everytime through and it figures when to ship? Or
add a 'ship' method and if it returns true, then called shipped (Is that right?
The method is 'shipped'. Have the KVs been shipped at this stage or does this
method ship them? If it ships them, the method should be 'ship' rather than
'shipped'?)
> Clear HFileScannerImpl#prevBlocks in between Compaction flow
> ------------------------------------------------------------
>
> Key: HBASE-14636
> URL: https://issues.apache.org/jira/browse/HBASE-14636
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-14636.patch, HBASE-14636.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
