[ 
https://issues.apache.org/jira/browse/HBASE-14636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964493#comment-14964493
 ] 

ramkrishna.s.vasudevan commented on HBASE-14636:
------------------------------------------------

bq.Also changed 2 secs interval based shipped call to a size based shipped call.
Okie. 
bq.If we go with size based I would suggest the size limit for check to be some 
thing like
HConstants.DEFAULT_BLOCKSIZE * conf.get(min_files_for_compact) -> So by def 64 
KB * 3 so that there is chance for at least one block will get cleared from 
prevBlocks list.
So we are sure that atleast one element is always there and that gets cleared. 
Should  be fine I think. 
As discussed yesterday and based on reports once we start clearing the prev 
blocks for the offheap compaction case I was not hitting the OOME even with 
heaps as lower as 2GB. 

> Clear HFileScannerImpl#prevBlocks in between Compaction flow
> ------------------------------------------------------------
>
>                 Key: HBASE-14636
>                 URL: https://issues.apache.org/jira/browse/HBASE-14636
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14636.patch, HBASE-14636.patch, 
> HBASE-14636_V2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to