[
https://issues.apache.org/jira/browse/HBASE-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964535#comment-14964535
]
Anoop Sam John commented on HBASE-14387:
----------------------------------------
{quote}
public long getMaxCompactSize(boolean mayUseOffpeak)
207 {
{quote}
Code format issue
bq.offPeakMaxCompactSize =
conf.getLong(HBASE_HSTORE_COMPACTION_MAX_SIZE_OFFPEAK_KEY, Long.MAX_VALUE);
Instead u can do
offPeakMaxCompactSize =
conf.getLong(HBASE_HSTORE_COMPACTION_MAX_SIZE_OFFPEAK_KEY, maxCompactSize );
Then u can avoid all the checks in getOffPeakMaxCompactSize, every time it is
getting called.
Pls add a release notes.
> Compaction improvements: Maximum off-peak compaction size
> ---------------------------------------------------------
>
> Key: HBASE-14387
> URL: https://issues.apache.org/jira/browse/HBASE-14387
> Project: HBase
> Issue Type: Improvement
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-14387-v1.patch
>
>
> Make max compaction size for peak and off peak separate config options.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
