[
https://issues.apache.org/jira/browse/HBASE-14655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969593#comment-14969593
]
Sergey Shelukhin commented on HBASE-14655:
------------------------------------------
left one comment on RB. One more question - is it possible to move all the if
(user == null) { blah() } else { cruft cruft cruft blah() cruft cruft } code
into separate methods like runBlahCpHook(), so that the code is cleaner.
> Narrow the scope of doAs() calls to region observer notifications for
> compaction
> --------------------------------------------------------------------------------
>
> Key: HBASE-14655
> URL: https://issues.apache.org/jira/browse/HBASE-14655
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 14655-0.98-v9.txt, 14655-branch-1-v5.txt,
> 14655-branch-1-v6.txt, 14655-branch-1-v7.txt, 14655-branch-1-v8.txt,
> 14655-branch-1-v9.txt, 14655-branch-1.0-v6.txt, 14655-branch-1.0-v7.txt,
> 14655-branch-1.0-v8.txt, 14655-branch-1.0-v9.txt, 14655-v1.txt, 14655-v2.txt,
> 14655-v3.txt, 14655-v4.txt, 14655-v5.txt, 14655-v6.txt, 14655-v7.txt,
> 14655-v8.txt, 14655-v9.txt
>
>
> As what has been done in HBASE-14631 and HBASE-14605, the scope of calling
> doAs() for compaction related region observer notifications should be
> narrowed.
> User object is passed from CompactSplitThread down to the methods where
> region observer notifications are made.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
