[
https://issues.apache.org/jira/browse/HBASE-14674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970433#comment-14970433
]
Hadoop QA commented on HBASE-14674:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12768187/HBASE-14674_v1.patch
against master branch at commit eb4f9b8b32cf0551088a342cfa9b46b20593ac27.
ATTACHMENT ID: 12768187
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1735 checkstyle errors (more than the master's current 1732 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16186//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16186//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16186//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16186//console
This message is automatically generated.
> Rpc handler / task monitoring seems to be broken after 0.98
> -----------------------------------------------------------
>
> Key: HBASE-14674
> URL: https://issues.apache.org/jira/browse/HBASE-14674
> Project: HBase
> Issue Type: Bug
> Reporter: Enis Soztutar
> Fix For: 1.3.0, 1.2.1, 1.0.3, 1.1.4, 0.98.17
>
> Attachments: HBASE-14674.patch, HBASE-14674_v1.patch
>
>
> In 0.96, we have the RPC handlers listed as tasks and show them in the web UI
> as well:
> {code}
> Tasks:
> ===========================================================
> Task: RpcServer.handler=0,port=64231
> Status: WAITING:Waiting for a call
> Running for 932s
> Task: RpcServer.handler=1,port=64231
> Status: WAITING:Waiting for a call
> Running for 932s
> Task: RpcServer.handler=2,port=64231
> Status: WAITING:Waiting for a call
> Running for 932s
> {code}
> After pluggable RPC scheduler, the way the tasks work for the handlers got
> changed. We no longer list idle RPC handlers in the tasks, but we register
> them dynamically to {{TaskMonitor}} through {{CallRunner}}. However, the IPC
> readers are still registered the old way (meaning that idle readers are
> listed as tasks, but not idle handlers).
> From the javadoc of {{MonitoredRPCHandlerImpl}}, it seems that we are NOT
> optimizing the allocation for the MonitoredTask anymore, but instead allocate
> one for every RPC call breaking the pattern (See CallRunner.getStatus()).
> {code}
> /**
> * A MonitoredTask implementation designed for use with RPC Handlers
> * handling frequent, short duration tasks. String concatenations and object
> * allocations are avoided in methods that will be hit by every RPC call.
> */
> @InterfaceAudience.Private
> public class MonitoredRPCHandlerImpl extends MonitoredTaskImpl
> {code}
> There is also one more side affect that, since the CallRunner is a per-RPC
> object and created in the RPC listener thread, the created task ends up
> having a name "listener" although the actual processing happens in a handler
> thread. This is obviously very confusing during debugging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
