[
https://issues.apache.org/jira/browse/HBASE-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139066#comment-13139066
]
Hadoop QA commented on HBASE-4696:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501369/HBASE-4696-v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -166 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.master.TestDefaultLoadBalancer
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/89//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/89//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/89//console
This message is automatically generated.
> HRegionThriftServer' might have to indefinitely do redirtects
> -------------------------------------------------------------
>
> Key: HBASE-4696
> URL: https://issues.apache.org/jira/browse/HBASE-4696
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.94.0
> Reporter: Prakash Khemani
> Assignee: Jonathan Gray
> Fix For: 0.94.0
>
> Attachments: HBASE-4696-v1.patch
>
>
> HRegionThriftServer.getRowWithColumnsTs() redirects the request to the
> correct region server if it has landed on the wrong region-server. With this
> approach the smart-client will never get a NotServingRegionException and it
> will never be able to invalidate its cache. It will indefinitely send the
> request to the wrong region server and the wrong region server will always be
> redirecting it.
> Either redirects should be turned off and the client should react to
> NotServingRegionExceptions.
> Or somehow a flag should be set in the response telling the client to refresh
> its cache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
