[ 
https://issues.apache.org/jira/browse/HBASE-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978268#comment-14978268
 ] 

Hadoop QA commented on HBASE-14704:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12768931/HBASE-14704.patch
  against master branch at commit bae94ca9729bec2e0fe3556a31e29a2444737b1f.
  ATTACHMENT ID: 12768931

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 28 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16258//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16258//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16258//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16258//console

This message is automatically generated.

> Block cache instances should be mapped to each region servers in standalone 
> mode or HBaseTestingUtility
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14704
>                 URL: https://issues.apache.org/jira/browse/HBASE-14704
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Eungsop Yoo
>            Priority: Minor
>         Attachments: HBASE-14704.patch
>
>
> CacheConfig has a single and static block cache instance. When HBase is 
> running in standalone mode or HBaseTestingUtility, a single instance of block 
> cache causes incorrect cache stats. So I suggest to change a single instance 
> of block cache to a map of region server and block cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to