[
https://issues.apache.org/jira/browse/HBASE-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978971#comment-14978971
]
Hadoop QA commented on HBASE-14675:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12769303/hbase-14675.v4.patch
against master branch at commit 51538c5ff89dd7ee8e32ef4895d10bfc58045b17.
ATTACHMENT ID: 12769303
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 517
new or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
Assert.assertFalse(destServer.getRegionsInTransitionInRS().containsKey(encodedRegionNameBytes));
+
Assert.assertFalse(curServer.getRegionsInTransitionInRS().containsKey(encodedRegionNameBytes));
+ sourceTable.getNameAsString(), FQ_OUTPUT_DIR.toString(), ";",
"^row1", "--starttime=" + now,
+ region.put(new Put(row).addColumn(fam, Bytes.toBytes("qual"),
System.currentTimeMillis() + 2000, Bytes.toBytes("value")));
+ put.addColumn(families.get(i % families.size()).getName(),
Bytes.toBytes("q"), Bytes.toBytes("val"));
+ put.addColumn(families.get(i % families.size()).getName(),
Bytes.toBytes("q"), Bytes.toBytes("val"));
+ put.addColumn(CellUtil.cloneFamily(firstVal),
CellUtil.cloneQualifier(firstVal), Bytes.toBytes("diff data"));
+ t.put(new
Put(TEST_ROW).addColumn(AccessControlLists.ACL_LIST_FAMILY, TEST_QUALIFIER,
TEST_VALUE));
+ p = new Put(TEST_ROW).addColumn(TEST_FAMILY1, TEST_Q1,
EnvironmentEdgeManager.currentTime() + 1000000, ZERO);
+ p = new Put(TEST_ROW).addColumn(TEST_FAMILY, TEST_Q3,
ZERO).addColumn(TEST_FAMILY, TEST_Q4, ZERO);
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16261//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16261//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16261//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16261//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16261//console
This message is automatically generated.
> Exorcise deprecated Put#add(...) and replace with Put#addColumn(...)
> --------------------------------------------------------------------
>
> Key: HBASE-14675
> URL: https://issues.apache.org/jira/browse/HBASE-14675
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 2.0.0
>
> Attachments: hbase-14675.patch, hbase-14675.patch,
> hbase-14675.v2.patch, hbase-14675.v3.patch, hbase-14675.v4.patch
>
>
> The Put API changed from #add(...) to #addColumn(...). This updates all
> instances of it and removes it from the Put (which was added for hbase 1.0.0)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
