[ 
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984073#comment-14984073
 ] 

stack commented on HBASE-14575:
-------------------------------

The original author says of the approach  "... I'm not sure if it's correct..." 
I'd be interested in a paragraph on why the current author thinks this patch is 
(correct). Also, what testing has been done on this approach? (Testing to 
verify the approach is what the original fellows working on this issue were 
most concerned about).

Giving the patch a quick review, yeah, it complicates HBASE-13082. It might 
work though given its passing the region lock... I tried to reason about it but 
was having trouble thinking through scenarios where a close could come in 
mid-compact or a bulk load. Would appreciate a write up what the current 
thinking is. Would help w/ this review (and I'm sure would help the fellow 
trying to land HBASE-13082)

Thanks.


> Reduce scope of compactions holding region lock
> -----------------------------------------------
>
>                 Key: HBASE-14575
>                 URL: https://issues.apache.org/jira/browse/HBASE-14575
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction, regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: 14575-v1.patch, 14575-v2.patch, 14575-v3.patch, 
> 14575-v4.patch, 14575.v00.patch
>
>
> Per [~devaraj]'s idea on parent issue, let's see if we can reduce the scope 
> of critical section under which compactions hold the region read lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to