[ 
https://issues.apache.org/jira/browse/HBASE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985150#comment-14985150
 ] 

Hadoop QA commented on HBASE-11393:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12770065/HBASE-11393_v5.patch
  against master branch at commit 6dbb5a8052c5cbff9dfb9ebac68d3200d3543955.
  ATTACHMENT ID: 12770065

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 11 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
1727 checkstyle errors (more than the master's current 1724 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.replication.TestPerTableCFReplication
                  
org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient
                  
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
                  
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas
                  
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters
                  org.apache.hadoop.hbase.client.TestCheckAndMutate
                  org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient
                  org.apache.hadoop.hbase.wal.TestDefaultWALProvider
                  org.apache.hadoop.hbase.client.TestPutWithDelete
                  org.apache.hadoop.hbase.replication.TestMasterReplication
                  org.apache.hadoop.hbase.client.TestReplicaWithCluster
                  org.apache.hadoop.hbase.client.TestShortCircuitConnection
                  org.apache.hadoop.hbase.client.TestMultipleTimestamps
                  org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
                  org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
                  org.apache.hadoop.hbase.client.TestFromClientSideNoCodec
                  org.apache.hadoop.hbase.client.TestClientPushback
                  org.apache.hadoop.hbase.wal.TestSecureWAL
                  org.apache.hadoop.hbase.client.TestFromClientSide3
                  org.apache.hadoop.hbase.client.TestTableSnapshotScanner
                  org.apache.hadoop.hbase.client.TestUpdateConfiguration
                  org.apache.hadoop.hbase.client.TestTimestampsFilter
                  org.apache.hadoop.hbase.client.TestScannerTimeout
                  org.apache.hadoop.hbase.TestMetaTableLocator
                  
org.apache.hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas
                  org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy
                  org.apache.hadoop.hbase.client.TestMetaWithReplicas
                  org.apache.hadoop.hbase.wal.TestWALFiltering
                  org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool
                  org.apache.hadoop.hbase.replication.TestReplicationWithTags
                  org.apache.hadoop.hbase.TestZooKeeper
                  org.apache.hadoop.hbase.client.TestHCM
                  
org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
                  org.apache.hadoop.hbase.wal.TestDefaultWALProviderWithHLogKey
                  org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
                  org.apache.hadoop.hbase.client.TestMultiParallel
                  org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover
                  org.apache.hadoop.hbase.wal.TestWALFactory
                  
org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
                  org.apache.hadoop.hbase.client.TestSizeFailures
                  org.apache.hadoop.hbase.TestIOFencing
                  
org.apache.hadoop.hbase.client.replication.TestReplicationAdmin

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16346//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16346//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16346//artifact/patchprocess/checkstyle-aggregate.html

                Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16346//console

This message is automatically generated.

> Replication TableCfs should be a PB object rather than a string
> ---------------------------------------------------------------
>
>                 Key: HBASE-11393
>                 URL: https://issues.apache.org/jira/browse/HBASE-11393
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11393.patch, HBASE-11393_v1.patch, 
> HBASE-11393_v2.patch, HBASE-11393_v3.patch, HBASE-11393_v4.patch, 
> HBASE-11393_v5.patch
>
>
> We concatenate the list of tables and column families in format  
> "table1:cf1,cf2;table2:cfA,cfB" in zookeeper for table-cf to replication peer 
> mapping. 
> This results in ugly parsing code. We should do this a PB object. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to