[
https://issues.apache.org/jira/browse/HBASE-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139915#comment-13139915
]
Harsh J commented on HBASE-4680:
--------------------------------
I apologize for missing the whole activity on this (didn't see a comment on
HBASE-4510, oops).
I think a better fix would have been to just catch other exceptions (which is
something I missed despite commenting).
This change is fine too, but has lead to HBASE-4705 scenarios. Could we revert
this and instead add a:
{code}
catch (Safemode) {
return true;
} catch (Others) {
ignore;
}
{code}
Kinda block, while still operating on the only dir guaranteed to exist (/ -
root)?
> FSUtils.isInSafeMode() checks should operate on HBase root dir, where we have
> permissions
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-4680
> URL: https://issues.apache.org/jira/browse/HBASE-4680
> Project: HBase
> Issue Type: Bug
> Components: util
> Affects Versions: 0.92.0, 0.94.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4680.patch
>
>
> The HDFS safe mode check workaround introduced by HBASE-4510 performs a
> {{FileSystem.setPermission()}} operation on the root directory ("/") when
> attempting to trigger a {{SafeModeException}}. As a result, it requires
> superuser privileges when running with DFS permission checking enabled.
> Changing the operations to act on the HBase root directory should be safe,
> since the master process must have write access to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
