[
https://issues.apache.org/jira/browse/HBASE-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991198#comment-14991198
]
stack commented on HBASE-14769:
-------------------------------
Very nice [~appy]
Do you know when getTableNames was deprecated sir?
Why ok to remove this?
public HTableDescriptor getTableDescriptor(final byte[] tableName)
567 throws TableNotFoundException, IOException {
568 return getTableDescriptor(TableName.valueOf(tableName));
569 }
Thats great you removed the redundant javadoc on @override
Why ok to remove this? It is not deprecated
public void enableTable(final byte[] tableName)
1019 throws IOException {
... and enableTableAsync?
Ditto disableTable... etc.
Yeah, so why is it ok removing all these methods... on public-looking class?
Will help the review sir.
Otherwise,, patch looks good.
> Remove unused functions and duplicate javadocs from HBaseAdmin
> ---------------------------------------------------------------
>
> Key: HBASE-14769
> URL: https://issues.apache.org/jira/browse/HBASE-14769
> Project: HBase
> Issue Type: Bug
> Reporter: Apekshit Sharma
> Assignee: Apekshit Sharma
> Attachments: HBASE-14769-master.patch
>
>
> HBaseAdmin is marked private, so removing the functions not being used
> anywhere.
> Also, the javadocs of overridden functions are same as corresponding ones in
> Admin.java. Since javadocs are automatically inherited from the interface
> class, we can remove these redundant 100s of lines.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
