[
https://issues.apache.org/jira/browse/HBASE-14737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991733#comment-14991733
]
Hadoop QA commented on HBASE-14737:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12770787/HBASE-14737.patch
against master branch at commit 050ebe850b32057860fb94b46f955352db139db1.
ATTACHMENT ID: 12770787
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16407//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16407//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16407//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16407//console
This message is automatically generated.
> Clear cachedMaxVersions when setValue(VERSIONS, value) called
> -------------------------------------------------------------
>
> Key: HBASE-14737
> URL: https://issues.apache.org/jira/browse/HBASE-14737
> Project: HBase
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Pankaj Kumar
> Attachments: HBASE-14737.patch
>
>
> HColumnDescriptor caches the value of VERSIONS in a cachedMaxVersions member
> variable. This member variable should be reset or cleared when
> setValue(HConstants.VERSIONS, value) is called, like this:
> {code}
> static final bytes[] VERSIONS_BYTES = Bytes.toBytes(HConstants.VERSIONS);
> public HColumnDescriptor setValue(byte[] key, byte[] value) {
> if (Bytes.compare(HConstants.VERSIONS_BYTES, key) == 0) {
> cachedMaxVersions = UNINITIALIZED;
> }
> values.put(new ImmutableBytesWritable(key),
> new ImmutableBytesWritable(value));
> return this;
> }
> {code}
> Otherwise, you continue getting back cachedMaxVersions instead of the updated
> value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
