[
https://issues.apache.org/jira/browse/HBASE-14776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993067#comment-14993067
]
Misty Stanley-Jones commented on HBASE-14776:
---------------------------------------------
For the passing - for stdin, I am not sure. I didn't think so. Maybe you can
tweak it. I don't understand enough about how the script works.
It didn't look like the script actually applied the patch anyway. Did it? If
so, that's easy enough to accomodate. In the case of 'git apply, we won't be
able to commit the change, and in the case of 'git am' we will have an extra
commit in the stack. It's a bit messy.
> Rewrite smart-apply-patch.sh to use 'git am' or 'git apply' rather than
> 'patch'
> -------------------------------------------------------------------------------
>
> Key: HBASE-14776
> URL: https://issues.apache.org/jira/browse/HBASE-14776
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 2.0.0
> Reporter: Misty Stanley-Jones
> Assignee: Misty Stanley-Jones
> Fix For: 2.0.0
>
> Attachments: HBASE-14776.patch
>
>
> We require patches to be created using 'git format-patch' or 'git diff', so
> patches should be tested using 'git am' or 'git apply', not 'patch -pX'. This
> causes false errors in the Jenkins patch tester.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
