[
https://issues.apache.org/jira/browse/HBASE-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14995011#comment-14995011
]
Hadoop QA commented on HBASE-14784:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12771142/HBASE-14784.patch
against master branch at commit 9cce912de01b7f2c6e968b0c9fdaccd93e44bebf.
ATTACHMENT ID: 12771142
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16440//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16440//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16440//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16440//console
This message is automatically generated.
> Port conflict is not resolved in HBaseTestingUtility.randomFreePort()
> ---------------------------------------------------------------------
>
> Key: HBASE-14784
> URL: https://issues.apache.org/jira/browse/HBASE-14784
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 1.1.2
> Reporter: Youngjoon Kim
> Assignee: Youngjoon Kim
> Priority: Minor
> Attachments: HBASE-14784.patch
>
>
> If takenRandomPorts.contains(port) == true, it means port conflict, so
> randomFreePort() should rerun the loop. But continue statement leads to exit
> the loop, because port != 0.
> {code:title=hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java}
> public static int randomFreePort() {
> int port = 0;
> do {
> port = randomPort();
> if (takenRandomPorts.contains(port)) {
> continue;
> }
> takenRandomPorts.add(port);
> ...
> } while (port == 0);
> return port;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
