[Differential] [Commented On] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

Mon, 31 Oct 2011 15:18:00 -0700 

mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty 
Printer print all the key values for a specific row.".

  A few more comments -- coding style only.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70 
Code style: add an empty line in here.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71-73 
Code style: make this one line if it fits in 80 chars, e.g.

    /** Your javadoc */
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:247 
Code style: this line is unnecessary
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:253 
This line is unnecessary because it does not say in what case the exception is 
thrown.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:251 if 
Row -> If row (capitalization)

REVISION DETAIL
  https://reviews.facebook.net/D111

Reply via email to