[ https://issues.apache.org/jira/browse/HBASE-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140628#comment-13140628 ]
Phabricator commented on HBASE-4698: ------------------------------------ mbautin has commented on the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.". A few more comments -- coding style only. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:70 Code style: add an empty line in here. src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71-73 Code style: make this one line if it fits in 80 chars, e.g. /** Your javadoc */ src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:247 Code style: this line is unnecessary src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:253 This line is unnecessary because it does not say in what case the exception is thrown. src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:251 if Row -> If row (capitalization) REVISION DETAIL https://reviews.facebook.net/D111 > Let the HFile Pretty Printer print all the key values for a specific row. > ------------------------------------------------------------------------- > > Key: HBASE-4698 > URL: https://issues.apache.org/jira/browse/HBASE-4698 > Project: HBase > Issue Type: New Feature > Reporter: Liyin Tang > Assignee: Liyin Tang > Attachments: D111.1.patch, D111.1.patch, D111.1.patch, D111.2.patch, > D111.3.patch > > > When using HFile Pretty Printer to debug HBase issues, > it would very nice to allow the Pretty Printer to seek to a specific row, and > only print all the key values for this row. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira