Liyin has requested changes to the revision "[jira] [HBASE-4686] [89-fb] Fix per-store metrics aggregation ".
Thanks Mikhail for the patch. There are some comments inline. INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:386 [code style] Please add an empty line here src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:554 Why not move this comments to line 551 ? src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:704 [code style] please remove this empty line here src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1148 [code style] Please write the standard java doc format src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1157 [code style] Please remove the empty line here src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1219 [code style] Please add an empty line here src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:90 [code style] Please remove the empty line here src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:119 [code style] Please remove the empty line here REVISION DETAIL https://reviews.facebook.net/D87
