[
https://issues.apache.org/jira/browse/HBASE-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140702#comment-13140702
]
Phabricator commented on HBASE-4686:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4686] [89-fb] Fix
per-store metrics aggregation
".
OK, this is now becoming a code style discussion, which is not a bad thing
once in a while :)
In general, the style guide for HBase seems to point to Oracle (former Sun)'s
coding conventions:
http://www.oracle.com/technetwork/java/codeconvtoc-136057.html, with the part
pertaining to Javadoc at
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html.
I guess it might not be a bad idea to actually read those docs some time...
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:386
Actually I a lot of places around the codebase don't have these empty lines
inside javadoc comments, and I think it is not necessary here. Java formatter
adds trailing whitespace to those empty lines, which is annoying. I did not
find a requirement that these lines have to be there at
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html
(although I did not read that entire style guide).
I will expand the documentation of tmpMap.
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:554
Will fix.
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:704
Agreed.
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1148 I think
this saves space and is OK for one-line comments. This parses fine by Javadoc.
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1157 This
empty line separates the bulky function header and the function body.
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:1219 I will
add one between 1218 and 1219.
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:90
OK.
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java:119
This one is a matter of preference. There is one at the top, so I will keep
the one at the bottom of the class definition.
REVISION DETAIL
https://reviews.facebook.net/D87
> [89-fb] Fix per-store metrics aggregation
> ------------------------------------------
>
> Key: HBASE-4686
> URL: https://issues.apache.org/jira/browse/HBASE-4686
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D87.1.patch, D87.2.patch, D87.3.patch,
> HBASE-4686-TestRegionServerMetics-and-Store-metric-a-20111027134023-cc718144.patch,
>
> HBASE-4686-jira-89-fb-Fix-per-store-metrics-aggregat-20111027152723-05bea421.patch
>
>
> In r1182034 per-Store metrics were broken, because the aggregation of
> StoreFile metrics over all stores in a region was replaced by overriding them
> every time. We saw these metrics drop by a factor of numRegions on a
> production cluster -- thanks to Kannan for noticing this! We need to fix the
> metrics and add a unit test to ensure regressions like this don't happen in
> the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
