[
https://issues.apache.org/jira/browse/HBASE-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005169#comment-15005169
]
Hadoop QA commented on HBASE-14802:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12772317/HBASE-14802-3.patch
against master branch at commit 789f8a5a70242c16ce10bc95401c51c7d04debfa.
ATTACHMENT ID: 12772317
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16518//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16518//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16518//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16518//console
This message is automatically generated.
> Replaying server crash recovery procedure after a failover causes incorrect
> handling of deadservers
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-14802
> URL: https://issues.apache.org/jira/browse/HBASE-14802
> Project: HBase
> Issue Type: Bug
> Components: master
> Affects Versions: 2.0.0, 1.2.0, 1.2.1
> Reporter: Ashu Pachauri
> Assignee: Ashu Pachauri
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14802-1.patch, HBASE-14802-2.patch,
> HBASE-14802-3.patch, HBASE-14802.patch
>
>
> The way dead servers are processed is that a ServerCrashProcedure is launched
> for a server after it is added to the dead servers list.
> Every time a server is added to the dead list, a counter "numProcessing" is
> incremented and it is decremented when a crash recovery procedure finishes.
> Since, adding a dead server and recovering it are two separate events, it can
> cause inconsistencies.
> If a master failover occurs in the middle of the crash recovery, the
> numProcessing counter resets but the ServerCrashProcedure is replayed by the
> new master. This causes the counter to go negative and makes the master think
> that dead servers are still in process of recovery.
> This has ramifications on the balancer that the balancer ceases to run after
> such a failover.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
