[ 
https://issues.apache.org/jira/browse/HBASE-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005647#comment-15005647
 ] 

Sean Busbey commented on HBASE-14803:
-------------------------------------

{code}
+  static final Log LOG = LogFactory.getLog(StoreFileScanner.class);
+
{code}

please make private

{code}
+    if (!reader.passesTimerangeFilter(timeRange, oldestUnexpiredTS)) {
+       if (LOG.isDebugEnabled()) {
+               LOG.debug (reader.getHFileReader().getName() + " skipped 
because of Timerange Filter.");
+       }
+       return false;
{code}

please use 2 spaces for indent and no tabs. (here and a few other instances)

> Add some debug logs to StoreFileScanner
> ---------------------------------------
>
>                 Key: HBASE-14803
>                 URL: https://issues.apache.org/jira/browse/HBASE-14803
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>              Labels: beginner
>             Fix For: 1.2.0
>
>         Attachments: HBASE-14803.v0-trunk.patch, HBASE-14803.v1-trunk.patch, 
> HBASE-14803.v2-trunk.patch
>
>
> To validate some behaviors I had to add some logs into StoreFileScanner.
> I think it can be interesting for other people looking for debuging. So 
> sharing the modifications here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to