[
https://issues.apache.org/jira/browse/HBASE-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesse Yates updated HBASE-14703:
--------------------------------
Attachment: HBASE-14703-v4.patch
I like this a lot more. Still wasn't a fan of the switching we had to do in the
async process, the time calculation logic semi-copy from retryingcaller and the
lack of tracking for the operation.
So, I took a crack at it. Now, the timeout tracking is encapsulated and reused
in the RetryingCaller and in the callable. I think its necessary in the
callable, since that is the thing being reused across calls. Then I added a new
callable class with the expectation of almost getting rid of
RegionServerCallable everywhere (except for Coprocessor calls) in favor of a
'PayloadCarryingCallable'; the new callable sets the
PayloadCarryingRpcController, allowing it to be canceled and saving the
creation in _every single use_ of RegionServerCallable that we'd eventually
replace. This lets us unify the interfaces in the progress tracking and cancel
the mutateRows call as well.
[~chenheng], your turn. What do you think?
> not collect stats when call HTable.mutateRow
> ---------------------------------------------
>
> Key: HBASE-14703
> URL: https://issues.apache.org/jira/browse/HBASE-14703
> Project: HBase
> Issue Type: Bug
> Reporter: Heng Chen
> Assignee: Heng Chen
> Attachments: HBASE-14703-async.patch, HBASE-14703-start.patch,
> HBASE-14703-v4.patch, HBASE-14703.patch, HBASE-14703_v1.patch,
> HBASE-14703_v2.patch, HBASE-14703_v3.patch
>
>
> In {{AsyncProcess.SingleServerRequestRunnable}}, it seems we update
> serverStatistics twice.
> The first one is that we wrapper {{RetryingCallable}} by
> {{StatsTrackingRpcRetryingCaller}}, and do serverStatistics update when we
> call {{callWithRetries}} and {{callWithoutRetries}}. Relates code like below:
> {code}
> @Override
> public T callWithRetries(RetryingCallable<T> callable, int callTimeout)
> throws IOException, RuntimeException {
> T result = delegate.callWithRetries(callable, callTimeout);
> return updateStatsAndUnwrap(result, callable);
> }
> @Override
> public T callWithoutRetries(RetryingCallable<T> callable, int callTimeout)
> throws IOException, RuntimeException {
> T result = delegate.callWithRetries(callable, callTimeout);
> return updateStatsAndUnwrap(result, callable);
> }
> {code}
> The secondary one is after we get response, in {{receiveMultiAction}}, we do
> update again.
> {code}
> // update the stats about the region, if its a user table. We don't want to
> slow down
> // updates to meta tables, especially from internal updates (master, etc).
> if (AsyncProcess.this.connection.getStatisticsTracker() != null) {
> result = ResultStatsUtil.updateStats(result,
> AsyncProcess.this.connection.getStatisticsTracker(), server, regionName);
> }
> {code}
> It seems that {{StatsTrackingRpcRetryingCaller}} is NOT necessary, remove it?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
