[ 
https://issues.apache.org/jira/browse/HBASE-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010814#comment-15010814
 ] 

Anoop Sam John commented on HBASE-14777:
----------------------------------------

nit:
bq.entryLists.remove((int)f.get());
f.get().intValue() can be a better choice?

Seeing the way we maintain these 2 lists of entryLists and futures, we maintain 
the same ordinal and not even we have to maintain the ordinal in the Runnable 
and return it may be.  The nth future item in futures List relates to nth item 
in entryList.  Ya for better understand ability of the code, let us not change 
that part.

+1 for the patch..  Great catch guys.

> Replication fails with IndexOutOfBoundsException
> ------------------------------------------------
>
>                 Key: HBASE-14777
>                 URL: https://issues.apache.org/jira/browse/HBASE-14777
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Bhupendra Kumar Jain
>            Assignee: Ashu Pachauri
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14777-1.patch, HBASE-14777-2.patch, 
> HBASE-14777-3.patch, HBASE-14777.patch
>
>
> Replication fails with IndexOutOfBoundsException 
> {code}
> regionserver.ReplicationSource$ReplicationSourceWorkerThread(939): 
> org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint
>  threw unknown exception:java.lang.IndexOutOfBoundsException: Index: 1, Size: 
> 1
>       at java.util.ArrayList.rangeCheck(Unknown Source)
>       at java.util.ArrayList.remove(Unknown Source)
>       at 
> org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.replicate(HBaseInterClusterReplicationEndpoint.java:222)
> {code}
> Its happening due to incorrect removal of entries from the replication 
> entries list. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to