[
https://issues.apache.org/jira/browse/HBASE-13347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018098#comment-15018098
]
Hadoop QA commented on HBASE-13347:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12773498/HBASE-13347-branch-1.patch
against branch-1 branch at commit 86be690b0723e814a655ad0ae8a6577d7111c1f2.
ATTACHMENT ID: 12773498
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16614//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16614//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16614//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16614//console
This message is automatically generated.
> Deprecate FirstKeyValueMatchingQualifiersFilter
> -----------------------------------------------
>
> Key: HBASE-13347
> URL: https://issues.apache.org/jira/browse/HBASE-13347
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Lars George
> Assignee: Abhishek Singh Chouhan
> Priority: Minor
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-13347-branch-1.patch, HBASE-13347-master-v2.patch,
> HBASE-13347-master.patch
>
>
> The {{RowCounter}} in the {{mapreduce}} package uses
> {{FirstKeyValueMatchingQualifiersFilter}} which was introduced in HBASE-6468.
> However we do not need that since we match columns in the scan before we
> filter.
> Deprecate the filter in 2.0 and remove in 3.0.
> Do cleanup of RowCounter that tries to use this filter but actually doesn't.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
