[
https://issues.apache.org/jira/browse/HBASE-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141410#comment-13141410
]
Ted Yu commented on HBASE-4716:
-------------------------------
bq. - in the case that this.closed flips true, it's calling
lock.writeLock.unlock() even if lock.readLock was taken. That's not correct.
I check whether write lock is held by current thread. Can you descibe in more
detail how lock.writeLock.unlock() would be called in the above scenario ?
The new boolean flag is only used in startBulkRegionOperation() so I didn't
introduce enum.
I will create isSingleFamilyBulkLoad().
As for style for if statement, I think one line method call can stay on the
same line.
> Improve locking for single column family bulk load
> --------------------------------------------------
>
> Key: HBASE-4716
> URL: https://issues.apache.org/jira/browse/HBASE-4716
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.0
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 4716.txt
>
>
> HBASE-4552 changed the locking behavior for single column family bulk load,
> namely we don't need to take write lock.
> A read lock would suffice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
